CocoaPods / search.cocoapods.org

This is the CocoaPods search engine repo, please direct CocoaPods issues to the main CocoaPods repository.
25 stars 11 forks source link

[Pod] Include subspec dependencies #64

Closed kylef closed 9 years ago

kylef commented 9 years ago

Closes #62 Closes #65

No tests, because: https://github.com/CocoaPods/search.cocoapods.org/blob/trunk-database-rewrite/spec/lib/models/pod_spec.rb :scream:

kylef commented 9 years ago

Btw, I don't have Ruby 2.1 and couldn't get the environment setup. So please test this works before merging :boom:.

floere commented 9 years ago

Can you please start a great tradition by adding a test in pod_spec? :) Also, how do you participate in CP without Ruby 2.1? (It's a matter of 10 minutes to set up a nice system with ruby-build and chruby)

floere commented 9 years ago

Here's a good example:

{"name"=>"AFNetworking", "version"=>"2.3.1", "license"=>"MIT", "summary"=>"A delightful iOS and OS X networking framework.", "homepage"=>"https://github.com/AFNetworking/AFNetworking", "social_media_url"=>"https://twitter.com/AFNetworking", "authors"=>{"Mattt Thompson"=>"m@mattt.me"}, "source"=>{"git"=>"https://github.com/AFNetworking/AFNetworking.git", "tag"=>"2.3.1", "submodules"=>true}, "requires_arc"=>true, "platforms"=>{"ios"=>"6.0", "osx"=>"10.8"}, "public_header_files"=>"AFNetworking/*.h", "source_files"=>"AFNetworking/AFNetworking.h", "subspecs"=>[{"name"=>"Serialization", "source_files"=>"AFNetworking/AFURL{Request,Response}Serialization.{h,m}", "ios"=>{"frameworks"=>["MobileCoreServices", "CoreGraphics"]}, "osx"=>{"frameworks"=>"CoreServices"}}, {"name"=>"Security", "source_files"=>"AFNetworking/AFSecurityPolicy.{h,m}", "frameworks"=>"Security"}, {"name"=>"Reachability", "source_files"=>"AFNetworking/AFNetworkReachabilityManager.{h,m}", "frameworks"=>"SystemConfiguration"}, {"name"=>"NSURLConnection", "dependencies"=>{"AFNetworking/Serialization"=>[], "AFNetworking/Reachability"=>[], "AFNetworking/Security"=>[]}, "source_files"=>["AFNetworking/AFURLConnectionOperation.{h,m}", "AFNetworking/AFHTTPRequestOperation.{h,m}", "AFNetworking/AFHTTPRequestOperationManager.{h,m}"]}, {"name"=>"NSURLSession", "dependencies"=>{"AFNetworking/Serialization"=>[], "AFNetworking/Reachability"=>[], "AFNetworking/Security"=>[]}, "source_files"=>["AFNetworking/AFURLSessionManager.{h,m}", "AFNetworking/AFHTTPSessionManager.{h,m}"]}, {"name"=>"UIKit", "platforms"=>{"ios"=>"6.0"}, "dependencies"=>{"AFNetworking/NSURLConnection"=>[], "AFNetworking/NSURLSession"=>[]}, "ios"=>{"public_header_files"=>"UIKit+AFNetworking/*.h", "source_files"=>"UIKit+AFNetworking"}, "osx"=>{"source_files"=>""}}]}
segiddins commented 9 years ago

I rebased + made some changes

floere commented 9 years ago

Would it be possible to add one spec here: https://github.com/CocoaPods/search.cocoapods.org/blob/trunk-database-rewrite/spec/lib/models/pod_spec.rb#L103 That would help me understand.

segiddins commented 9 years ago

I tried to but ran into https://github.com/CocoaPods/search.cocoapods.org/issues/67

floere commented 9 years ago

I just pushed a commit where we load the pod from the DB.

segiddins commented 9 years ago

Ace. Will try and add specs in the morning, but I'm still wrapping my head around how this app works.

-Samuel E. Giddins

On Nov 7, 2014, at 12:00 AM, Florian R. Hanke notifications@github.com wrote:

I just pushed a commit where we load the pod from the DB.

— Reply to this email directly or view it on GitHub.

floere commented 9 years ago

I'm planning to add an architecture document tomorrow – that should help.

floere commented 9 years ago

Does this help? https://github.com/CocoaPods/search.cocoapods.org/blob/trunk-database-rewrite/ARCHITECTURE.md

orta commented 9 years ago

don't forget thisssss

segiddins commented 9 years ago

I know, I haven't forgotten this... I'm sorry I dropped the ball. I'll try and pick it up soon.