search

CocoaPods / search.cocoapods.org

This is the CocoaPods search engine repo, please direct CocoaPods issues to the main CocoaPods repository.
25 stars 11 forks source link

Name link trips up the JavaScript. #7

Closed floere closed 11 years ago

floere commented 12 years ago

E.g. "Jonathan 'Wolf' Rentzsch", due to unescaped quotes.

keith commented 11 years ago

I'm not sure when this changed either but this has also been resolved.

floere commented 11 years ago

No it hasn't. Steps to reproduce:

  1. Go here http://cocoapods.org/?q=jonathan%20wolf
  2. Click on the name.
keith commented 11 years ago

I'm sorry you're right I misunderstood what you meant.

Keith Smiley

On Saturday, December 22, 2012 at 3:58 PM, Florian R. Hanke wrote:

No it hasn't. Steps to reproduce: Go here http://cocoapods.org/?q=jonathan%20wolf
Click on the name.

— Reply to this email directly or view it on GitHub (https://github.com/CocoaPods/cocoapods.org/issues/7#issuecomment-11641265).

floere commented 11 years ago

No worries! :) Am 23.12.2012 09:38 schrieb "Keith Smiley" notifications@github.com:

I'm sorry you're right I misunderstood what you meant.

Keith Smiley

On Saturday, December 22, 2012 at 3:58 PM, Florian R. Hanke wrote:

No it hasn't. Steps to reproduce: Go here http://cocoapods.org/?q=jonathan%20wolf Click on the name.

— Reply to this email directly or view it on GitHub ( https://github.com/CocoaPods/cocoapods.org/issues/7#issuecomment-11641265).

— Reply to this email directly or view it on GitHubhttps://github.com/CocoaPods/cocoapods.org/issues/7#issuecomment-11642094.

keith commented 11 years ago

I fixed it for real with this commit, https://github.com/CocoaPods/cocoapods.org/commit/034fca561fbb9d3286e9ca99e0ba0510bed0221e. Now I need to figure out who can push it to Heroku.

keith commented 11 years ago

Done on the live site for real this time. Thanks again!

floere commented 11 years ago

Thanks, @Keithbsmiley! :)

keith commented 11 years ago

:-)