Cocoanetics / DTFoundation

Standard toolset classes and categories
BSD 2-Clause "Simplified" License
802 stars 237 forks source link

Enable DTFoundation to be built within apps with bitcode enabled #131

Closed vincentleclerc closed 3 years ago

vincentleclerc commented 3 years ago

Hi there,

I've had issues with bitcode since I imported your framework. I've seen this issue mentioned multiple times online about your lib without any resolution, so I came up with the fix myself. The original error is thrown every time we try to build a target that has bitcode enabled. ->

bitcode bundle could not be generated because '.../DTCoreText.o' was built without full bitcode. All object files and libraries for bitcode must be generated from Xcode Archive or Install build file '.../DTCoreText.o' for architecture arm64

This error is specific to DTCoreText, but since DTCoreText has the dependency of DTFoundation, both have to be able to be built with bitcode. The flags to enable bitcode are missing in both frameworks. I also have a PR for DTCoreText when this one is gonna be merged.

odrobnik commented 3 years ago

Thanks for the PR!