search

Cocoanetics / DTFoundation

Standard toolset classes and categories
BSD 2-Clause "Simplified" License
805 stars 237 forks source link

Added more 64 bits CGFloat support. #87

Closed jcbertin closed 9 years ago

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.05%) when pulling a0edc5b6735c6ec651c519e00acaaea9eba1094a on jcbertin:develop into 6d22fe2b642584e47c7ca4e55ee4041883de4da3 on Cocoanetics:develop.

odrobnik commented 9 years ago

Why do you replace some CGFloat with ordinary floats?

jcbertin commented 9 years ago

I've just changed the type of percentProgress in DTPieProgressIndicator because you don't need double precision for that kind of data. Apple's API use floats where double precision is not really needed like CALayer.opacity, AVPlayer.rate or AVPlayer.volume.

jcbertin commented 9 years ago

any comments for the use of floats instead of CGFloat?

odrobnik commented 9 years ago

@jcbertin I merged it, even though I am not exactly certain what the benefit would be. But thanks for your efforts!

jcbertin commented 9 years ago

I agree that the benefit is very light but you really don't need double precision for a progress indicator and less is always better.

Regards.