ICSharpCode.SharpZipLib.Zip;

Cocos2DXNA / cocos2d-xna

XNA Port of Cocos2d-X

www.cocos2dxna.com

227 stars 123 forks source link

ICSharpCode.SharpZipLib.Zip; #413

Closed Zambiorix closed 10 years ago

Zambiorix commented 10 years ago

The use of ICSharpCode.SharpZipLib.Zip; is minimal, only in CCParticleSystem.cs For xbox360 even a reduced code set used.

Consider adding the reduced code to the project, in its own namespace (much like you do with the zlib code), and removing the reference to the (changed) dll.

IMO less dependancies is better than more

totallyeviljake commented 10 years ago

Agreee. We use a custom source build of that project for WP8 already. The problem with that library is that it is highly disconnected internally.

Zambiorix commented 10 years ago

I have sent a pull request where the SharpZlib code is integrated in the iOS & Android Projects (not et for other platforms).

This uses the same approach as what you did with the zlib code