CodSpeedHQ / codspeed-rust

Rust crates to create CodSpeed benchmarks
https://codspeed.io
Apache License 2.0
24 stars 9 forks source link

feat(cargo-codspeed): build all benches in a single cargo build #34

Closed adriencaccia closed 9 months ago

adriencaccia commented 9 months ago

As pointed out by @Boshen in https://github.com/oxc-project/oxc/pull/2343, we can build all the benches in a single command.

codspeed-hq[bot] commented 9 months ago

CodSpeed Performance Report

Merging #34 will improve performances by 14.2%

Comparing feat/single-build (69c8309) with main (fc75139)

Summary

⚡ 3 improvements ✅ 54 untouched benchmarks

Benchmarks breakdown

Benchmark main feat/single-build Change
Auto 223.3 ns 195.6 ns +14.2%
Linear 223.3 ns 195.6 ns +14.2%
Flat 728.3 ns 700.6 ns +3.97%
adriencaccia commented 9 months ago

@art049 I made the changes, let me know if it's okay to merge. I don't really know what to make of the performance improvements of the criterion sampling modes benchmarks.

art049 commented 9 months ago

LGTM, @adriencaccia; those benches are relying on sleep. Thus we end up with syscall variance.