CodSpeedHQ / pytest-codspeed

Pytest plugin to create CodSpeed benchmarks
https://codspeed.io
MIT License
53 stars 6 forks source link

Fix `stdout`/`stderr` redirects #25

Open kenodegard opened 6 months ago

kenodegard commented 6 months ago

Resolves #24

Changes include:

jezdez commented 6 months ago

Nice, thanks @kenodegard!

codspeed-hq[bot] commented 6 months ago

CodSpeed Performance Report

Merging #25 will not alter performance

Comparing kenodegard:fix-outerr-redirects (26b5d09) with master (90e639b)

Summary

✅ 5 untouched benchmarks

kenodegard commented 6 months ago

@art049 thanks for running the tests

pushed https://github.com/CodSpeedHQ/pytest-codspeed/pull/25/commits/59ea7ad0db3af9e0edee4630cd01b99352afaaa3 to resolve the typing failure in Python<3.10 and https://github.com/CodSpeedHQ/pytest-codspeed/pull/25/commits/2b026dd7d52fb8e165849ad059276b7b65cb429d to resolve the perf trampoline test failure on Python 3.12

kenodegard commented 6 months ago

@art049 anything more to do here?

art049 commented 5 months ago

It's a bit annoying that formatter changes and logic change are in the same PR in the end. I'll maybe try to split things out.