search

CodSpeedHQ / pytest-codspeed

Pytest plugin to create CodSpeed benchmarks
https://codspeed.io
MIT License
53 stars 6 forks source link

Error during CI with valgrind #7

Closed armgilles closed 1 year ago

armgilles commented 1 year ago

Hi @art049

I wanted to test a bit pytest-codspeed but I get an error that I can't fix : 

Run CodSpeedHQ/action@v1

   ______            __ _____                         __
  / ____/____   ____/ // ___/ ____   ___   ___   ____/ /
 / /    / __ \ / __  / \__ \ / __ \ / _ \ / _ \ / __  /
/ /___ / /_/ // /_/ / ___/ // /_/ //  __//  __// /_/ /
\____/ \____/ \__,_/ /____// .___/ \___/ \___/ \__,_/
  https://codspeed.io/     /_/          runner v1.5.0

Prepare environment
  Environment ready
Run benchmarks
  valgrind: Bad option: --collect-systime=nsec
  valgrind: Invalid boolean value 'nsec' (should be 'yes' or 'no')
  valgrind: Use --help for more information or consult the user manual.
  Error: Failed to run benchmarks

PR with code : https://github.com/armgilles/vcub_keeper/pull/77#issuecomment-1484045930

Maybe I did something wrong ?

Cheer's from Bordeaux :)

art049 commented 1 year ago

Hello Armand,

Thanks for the feedback. I think it comes from the version of Valgrind distributed with this release of ubuntu in the workflow. Could you try with runs-on: ubuntu-22.04

I will add a check in the action that puts a clearer message and also, specify it in the doc!

Very interesting project by the way, I didn't think there would be so much I didn't think there would be so many problems with the bike-sharing stations.

(translated to English, I didn't see this was on GitHub 😅)

On Sun, Mar 26, 2023 at 11:59 AM GILLES Armand @.***> wrote:

Hi @art049 https://github.com/art049

I wanted to test a bit pytest-codspeed but I get an error that I can't fix :

Run @.***

/ / __/ // _/ __ _ __/ / / / / \ / _ / \ \ / \ / \ / \ / / / /_ / // // // / / // // // // // // /__/ __/ _,_/ /__// ./ \/ _/ \,/ https://codspeed.io/ // runner v1.5.0

Prepare environment Environment ready Run benchmarks valgrind: Bad option: --collect-systime=nsec valgrind: Invalid boolean value 'nsec' (should be 'yes' or 'no') valgrind: Use --help for more information or consult the user manual. Error: Failed to run benchmarks

PR with code : armgilles/vcub_keeper#77 (comment) https://github.com/armgilles/vcub_keeper/pull/77#issuecomment-1484045930

Maybe I did something wrong ?

Cheer's from Bordeaux :)

— Reply to this email directly, view it on GitHub https://github.com/CodSpeedHQ/pytest-codspeed/issues/7, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXKX2JODDVPKBIDAC4B3LLW6AORZANCNFSM6AAAAAAWICSJZI . You are receiving this because you were mentioned.Message ID: @.***>

armgilles commented 1 year ago

Je vais test sur un ubuntu-22.04, ça me donnera une raison de faire une montée de version sur mon serveur !

C'est un bon projet bac à sable et qui a le mérite de répondre à une vraie problématique avec des données open-data (qui changent donc souvent :( ). C'est l'occasion aussi de tester de nouvelles choses (comme codspeed).

Je reviens vers toi pour te tenir au courant !

Armand

armgilles commented 1 year ago

Passing to ubuntu-22.04 fix the problem.

I've other problems (https://github.com/armgilles/vcub_keeper/pull/77#issuecomment-1493379061) but different issue.