search

Coda1552 / bettas

A small mod containing a new fish: the betta!
4 stars 4 forks source link

bettas:moss_ball ConfiguredFeature seems to be not registered #3

Open TelepathicGrunt opened 3 years ago

TelepathicGrunt commented 3 years ago

Hello! I was running my mod called Blame with Bettas on and it seemed to have found that the bettas's moss ball ConfiguredFeature is not registered. This can be an issue for mod compatibility as under certain conditions, unregistered ConfiguredFeatures can basically prevent other mod's registered ConfiguredFeatures from spawning if in the same generation stage.

By that I mean, if mod A adds an unregistered CF to the ore generation stage and the biome's codec reaches it first, it will choke and basically nuke mob B's registered CFs afterwards. Here's a case where BetterCaves forgot to register their CF and caused several CFs from Oh The Biomes You'll Go to stop spawning in the world: yungnickyoung/YUNGs-Better-Caves#75

Here's a more detailed explanation of why this happens in the biome's codec: image

Specifically, when you call .withConfiguration on a Feature, you create a ConfiguredFeature. This is what should be registered to the WorldgenRegisties at mod init (you can do it in FMLCommonSetupEvent so you have your config ready too if it is needed).

Anyway here's an example from my mod RepurposedStructures of me registering all my ConfiguredFeatures. https://github.com/TelepathicGrunt/RepurposedStructures/blob/584433a0745338802c84e9f498dc063c1f5505f8/src/main/java/com/telepathicgrunt/repurposedstructures/modinit/RSConfiguredStructures.java#L72-L74

I hope this helps!

Coda1552 commented 3 years ago

I'll take a look at it, thanks :)

MWall541 commented 3 years ago

this man is everywhere