why hardcode the path to the binary?

[jjb]

Hi, thanks for a great project.

I use macports, so terminal-notifier-guard doesn't find my terminal-notifier executable.

Why are you hardcoding the path to the binary? When I install terminal-notifier with macports, it is available in my executable path.

➔ type terminal-notifier
terminal-notifier is /opt/local/bin/terminal-notifier
➔ cat /opt/local/bin/terminal-notifier
#!/bin/sh
exec /opt/local/libexec/terminal-notifier.app/Contents/MacOS/terminal-notifier "$@"

I imagine this is also the case with Homebrew, no?

[costa]

+1 Back to 1.5.3

[wearethefoos]

@jjb @costa could you try with the fixes in fixes/hardcoded-bin-path.

# Gemfile
gem 'terminal-notifier-guard', git: "https://github.com/Springest/terminal-notifier-guard.git", branch: "fixes/hardcoded-bin-path"

If that works for you, we can release a new version.

Thanks.

[jjb]

it works!

there is a missing image, not sure which gem is responsible for that, probably not terminal-notifier-guard…

[wearethefoos]

Great! Thanks for testing @jjb. I just released the fixes in 1.6.3 to rubygems.

That missing image should be a terminal icon btw, bundled with terminal-notifier as far as I can see. You might need to check the app bundle for that. Could also be a cache issue, not sure.

[costa]

Ok, it worked after I added terminal-notifier to the bundle. Now, an unrelated question, why is this repository is a fork of the terminal-notifier? ;)