search

Codaisseur / terminal-notifier-guard

Mac OS X User Notifications for Guard
Other
163 stars 25 forks source link

Not working on OS X 10.9 Mavericks #7

Closed karl closed 9 years ago

karl commented 10 years ago

It looks like terminal-notifier-guard doesn't work on OS X 10.9 Mavericks.

This could be because terminal-notifier requires the -sender parameter in 10.9 or the notification is never shown.

See this comment on a terminal-notifier issue: https://github.com/alloy/terminal-notifier/issues/57#issuecomment-26893492

graygilmore commented 10 years ago

There is a PR for it: https://github.com/alloy/terminal-notifier/pull/60

ballPointPenguin commented 10 years ago

I did brew install terminal-notifier and downloaded v. 1.5.1 which is working with Mavericks. How to I get terminal-notifier-guard to use this new version?

jamilbk commented 10 years ago

@ballPointPenguin I hacked together a workaround. It checks to see if you have terminal-notifier in your PATH and uses that if so. Try adding this to your Gemfile until this gets fixed:

gem 'terminal-notifier-guard', github: 'elbii/terminal-notifier-guard', branch: :check_path

See my pull request https://github.com/Springest/terminal-notifier-guard/pull/8

saghaulor commented 10 years ago

@jamilbk your hack didn't seem to fix the issue for me, although I'm not certain that I'm affected. I receive some notifications, namely, "Jammit successfully packaged the assets", but I don't receive any rspec notifications. Moreover, the same behavior was exhibited before and after your patch.

gsong commented 10 years ago

For me, terminal-notifier-notify works, but the other three wrappers do not show any messages.

leods92 commented 10 years ago

Once I updated guard to the 2.x version I started having problems. They’ve refactored the notification systems handler so maybe that’s the problem. After downgrading I had everything back on track.

Am 12.Dez..2013 um 15:58 schrieb George Song notifications@github.com:

For me, terminal-notifier-notify works, but the other three wrappers do not show any messages.

— Reply to this email directly or view it on GitHub.

gsong commented 10 years ago

@leods92 In my case, I was testing terminal-notifier-guard directly, not through guard.

Turns out everything worked once I restarted Notification Center in Activity Monitor.

ballPointPenguin commented 10 years ago

working fine for me guard 2.2.5 guard-rspec 4.2.0 terminal-notifier-guard 1.5.3 terminal-notifier 1.5.1 OS X 10.9

suan commented 10 years ago

The following is not working for me:

guard 1.4.0 guard-rspec 1.2.1 terminal-notifier-guard 1.5.3 terminal-notifier 1.5.1 OSX 10.9

@leods92 What guard version did you downgrade to?

robnasby commented 10 years ago

Also not working for me:

OS X 10.9 guard 2.6.1 guard-minitest 2.3.1 terminal-notifier 2.6.0 terminal-notifier-guard 1.5.3

Guard correctly detects changes and reruns the tests. But it isn't reporting results using Notification Center. I tested terminal-notifier and it works like a charm...

wearethefoos commented 9 years ago

Please update to version 1.6.1.