Codaone / DEXBot

Trading Bot for the BitShares Decentralized Exchange
Other
247 stars 127 forks source link

[Logic] Trading of asset disabled by issuer #183

Open MarkoPaasila opened 6 years ago

MarkoPaasila commented 6 years ago

This error message:

 File "/usr/local/lib/python3.5/dist-packages/grapheneapi/graphenewsrpc.py", line 173, in rpcexec
    raise RPCError(ret['error']['message'])
grapheneapi.exceptions.RPCError: Assert Exception: is_authorized_asset( d, *_seller, *_receive_asset ):

means that the issuer of the asset we are trying to trade has disabled trading temporarily or semi-permanently. This doesn't happen so often, but when it happens it will frustrate many users. We should handle this error properly either by

  1. displaying the user a message and stopping the affected worker, or by
  2. slowing down and retrying once every hour until trading is resumed.

Any other ideas?

litepresence commented 6 years ago

interesting, in my (non DEXbot but pybitshares using) scripts the error was

RPCError: Assert Exception: _sell_asset->options.whitelist_markets.find(_receive_asset->id) != _sell_asset->options.whitelist_markets.end()

same thoughts though; assertion arguments are very confusing for the user

https://github.com/bitshares/bitshares-core/issues/1018

thehapax commented 5 years ago

@MarkoPaasila shall we close or this issue still a concern?

MarkoPaasila commented 5 years ago

It's pretty rare, but also simple. Just one specific exception. Backlog?

thehapax commented 5 years ago

@MarkoPaasila changing status to available for any one who wants to take ownership