search

Codarama / diet-engine

Diet significantly minimizes the space used by your project's /lib
codarama.github.io/Diet
MIT License
3 stars 2 forks source link

Do we handle inner classes #23

Open tishun opened 9 years ago

tishun commented 9 years ago

If we include a new dependency do we also include it's inner classes?

I only ask because I encountered such an issue when I run a functional test on the maven plugin a few moments ago. BCEL refused to confirm that the inner class is a class by the way.

ayld commented 9 years ago

AFAIK inner classes need their imports in the parent, so we should handle them. I've seen classes like 'class$1' bundled so we've detected some. I'm not sure what would happen if the binary class resolver doesn't detect them though, but I think it does. We need a unit test for this specifically.

ayld commented 9 years ago

@tishun What do you mean by "BCEL refused to confirm that the inner class is a class by the way.", exactly? What did you try (in the code), what happened, can I unit test this somehow? I'm writing a test right now, but I'm unsure what to test exactly.