Codarama / diet-maven-mojo

A maven mojo that utilizes the diet-core to slimify the project and its dependencies
diet.codarama.org
MIT License
2 stars 0 forks source link

Add <keepOriginalArtifact> configuration element #8

Open ayld opened 7 years ago

ayld commented 7 years ago

Something like <replaceArtifact>true</replaceArtifact> in the mojo config.

Currently when we minimize a project we get this in /target: target/currentProjectArtifact.jar target/currentProjectArtifact_minimized.jar

Keeping the original for "safety". In the spirit of being as "single click" as possible it might be better to have: target/currentProjectArtifact.jar (this is the minimized one) target/currentProjectArtifact_original.jar (this is the original non-minimized one)

So perhaps two settings? <replaceArtifact>true</replaceArtifact> (to make the currentProjectArtifact.jar be the minimized one) and <keepOriginal>true</keepOriginal> (to keep the original?)

Thoughts?

tishun commented 7 years ago

Two parts 💯 ( 50/50 )

What do you think?

ayld commented 7 years ago

My thoughts exactly.

So it should be: target/currentProjectArtifact.jar (this is the minimized one) target/currentProjectArtifact_original.jar (this is the original non-minimized one)