Code-4-Community / outstanding-life

Virtual Senior Center, made with Next, React, Postgres, and Node.
2 stars 0 forks source link

add dotenv dependency #73

Closed yanDavid21 closed 2 years ago

yanDavid21 commented 2 years ago

ℹī¸ Issue

Closes #72

📝 Description

Briefly list the changes made to the code:

✔ī¸ Verification

*these variables can found in aws cognitor, but can message @yanDavid21 @jessicasu77 for more information as well

Provide screenshots of any new components, styling changes, or pages.

image

🏕ī¸ (Optional) Future Work / Notes

Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!

This works for local development. For production, we would need to host our nextjs app on ec2 or similar computing option. Then we would need to generate a new ,env there for the prod cognito client (osl_client_nextjs_prod) with a new callback url in App client settings (again for osl_client_nextjs_prod). Additionally, we need to generate a next_auth_secret for production (and also switch our app in production for production ;) (in dockerfile)).

rymaju commented 2 years ago

My understanding was that environment variables were built into Next via .env.local as described here: https://nextjs.org/docs/basic-features/environment-variables

yanDavid21 commented 2 years ago

My understanding was that environment variables were built into Next via .env.local as described here: https://nextjs.org/docs/basic-features/environment-variables

Thanks for the heads up. Looks like a nonfunctional change, we'll look to refactor this then. @jessicasu77

yanDavid21 commented 2 years ago

Looks good so far! @yanDavid21 and @jessicasu77 would you like to make a new ticket for refactoring or just continue working off of this one? I'll wait for the updates to approve then

We'll update this branch. Don't think we should make a new ticket since we're not going to commit these changes.

jessicasu77 commented 2 years ago

looks good so far! @jessicasu77 were you able to load outstandinglife.org even with postgres issues? I'm going to get that to work first so that I can see that being signed in leads to outstandingelife.org , but after that I'll approve!

Wasn't able to sign in without fixing the postgres issue