search

Code-Egg / collection

A quick setup performing wordpress site method
5 stars 2 forks source link

php_max_execution_time var does not have a default #3

Open insanity54 opened 2 years ago

insanity54 commented 2 years ago

Thank you for this collection!

When I ran a playbook using code_egg.openlitespeed_wordpress.php, I saw the following task failure.

TASK [code_egg.openlitespeed_wordpress.php : Set max_execution_time] ********************************
fatal: [144.202.70.47]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'php_max_execution_time' is undefined\n\nThe error appears to be in '/home/chris/.ansible/collections/ansible_collections/code_egg/openlitespeed_wordpress/roles/php/tasks/main.yml': line 28, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Set max_execution_time\n  ^ here\n"}

Looks like the variable defaults are missing php_max_execution_time. I did not think to set it myself, but I think it makes sense for a default to be there

Code-Egg commented 2 years ago

Although I can not reproduce this issue, I have included the value in the latest commit. I will close the issue once you verified, thanks for the report.