search

Code-House / bacnet4j-wrapper

Simple facade for bacnet4j api.
GNU General Public License v3.0
48 stars 20 forks source link

Multiple devices on single IP causes errors #6

Closed splatch closed 5 years ago

splatch commented 6 years ago

Reported on openhab forums:

Exception in thread “bacnet-client-2-discovery” java.lang.IllegalArgumentException: Not an I/P mac
at com.serotonin.bacnet4j.npdu.ip.IpNetworkUtils.getIpBytes(IpNetworkUtils.java:115)
at com.serotonin.bacnet4j.npdu.ip.IpNetworkUtils.toIpString(IpNetworkUtils.java:106)
at com.serotonin.bacnet4j.npdu.ip.IpNetworkUtils.toIpPortString(IpNetworkUtils.java:110)
at com.serotonin.bacnet4j.npdu.ip.IpNetworkUtils.toString(IpNetworkUtils.java:122)
at org.code_house.bacnet4j.wrapper.api.Device.toString(Device.java:114)
at java.lang.String.valueOf(String.java:2994)
at java.lang.StringBuilder.append(StringBuilder.java:131)
at org.openhab.binding.bacnet.internal.BacNetBinding.deviceDiscovered(BacNetBinding.java:250)
at org.code_house.bacnet4j.wrapper.api.DiscoveryCallable.iAmReceived(DiscoveryCallable.java:89)
at org.code_house.bacnet4j.wrapper.api.util.ForwardingAdapter$2.run(ForwardingAdapter.java:77)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)

https://community.openhab.org/t/bacnet-binding-error-on-start/38822

splatch commented 5 years ago

This issue was resolved, additional safety measure was introduced in 623654f478e07ef195f19124759b2f3d803426c3.