search

Code-Inspect / flowr

A program slicer and dataflow analyzer for the R programming language.
https://github.com/Code-Inspect/flowr/wiki
GNU General Public License v3.0
14 stars 2 forks source link

Improve dependency management for flowr #714

Closed Ellpeck closed 3 months ago

Ellpeck commented 3 months ago

Apparently webpack, in its infinite wisdom, thinks node:readline means "readline is to be found by using the protocol node://", which is.. what.

But alas, node: is a redundant prefix so we just remove it. That should fix it. Apparently. I'm going to cry.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.13%. Comparing base (d4ad9bd) to head (98a04fd). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #714 +/- ## ======================================= Coverage 71.13% 71.13% ======================================= Files 217 217 Lines 7033 7033 Branches 1095 1095 ======================================= Hits 5003 5003 Misses 1738 1738 Partials 292 292 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Ellpeck commented 3 months ago

There doesn't appear to be a rule for not preferring the node: protocol prefix :(

EagleoutIce commented 3 months ago

This pull request is included in v1.4.2 (see Release v1.4.2 (Dropping xmlparsedata, Benchmark Re-Runs, and Repl Fixes)).