Code-Inspect / flowr

A program slicer and dataflow analyzer for the R programming language.
https://github.com/Code-Inspect/flowr/wiki
GNU General Public License v3.0
14 stars 2 forks source link

Claims don't match tests for some labels #820

Closed Ellpeck closed 1 month ago

Ellpeck commented 1 month ago

Notably, the labels built-in-sequencing and accessing-internal-names have the unsupported claim, but various tests that claim to include them.

EagleoutIce commented 1 month ago

Can you be more specific please? Are these the only ones?

Ellpeck commented 1 month ago

Yes, it appears that way. Here are their reports:

    [1/2/9] Accessing Internal Names (claim: not supported) is covered by 1 test:
          - desugar [1]: #304

      [2/1/10/3] Sequencing (claim: not supported) is covered by 22 tests:
            - dataflow [5]: #69-#70, #99, #119-#120
            - desugar [7]: #400-#404, #490-#491
            - slice [10]: #647, #653-#654, #660-#666
            - output [2]: #647, #660
EagleoutIce commented 1 month ago

So, the access of internal names label should be removed as we just use the ::: token and not really resolve anything there. Sequencing on the other hand should be updated like this: 1) the description in data.ts should state that this refers to the abstract interpretation support (i.e., contributing information on the value domain). Consequently, the label should be removed from all tests exposing it (or in other words, we treat it as a simple binary operator). Can you do that? @Ellpeck

EagleoutIce commented 1 month ago

This issue has been resolved in v2.0.2 (see Release v2.0.2 (Fixing Control-Flow, Markdown-Exports, and Handling of Unnamed Closures)).