Feature project should have customisable task activity list

Code-Poets / sheetstorm

Web working hours sheet for Code-Poets employees

https://www.sheetstorm.codepoets.it

2 stars 0 forks source link

Feature project should have customisable task activity list #460

Closed Szymiks closed 5 years ago

Szymiks commented 5 years ago

Resolves: https://github.com/Code-Poets/sheetstorm/issues/204

This PR will be change because @Karrp want this feature in differemt way. Related:https://github.com/Code-Poets/sheetstorm/pull/469

In this PR I just created few things: Should be done

create fields in task_activite_models - projects - m2m and is_default
refactor singals to signals.py in manager app because I had problems with import TaskActivityType in models in manager app and import Project in models in employee app.
view when Admin and manager could manage project task activities or create new one.

Will be done in next PR

add view for Admin to manage all task activities
add dynamic filter during filling report

Question I have never done something like this, so when I should make some script or something to set default task activity list for all existing projects?

Szymiks commented 5 years ago

@Karrp Could you say what task activities should be default for all projects or maybe talk about it with Adrian ? :)

rwrzesien commented 5 years ago

I have never done something like this, so when I should make some script or something to set default task activity list for all existing projects?

For existing projects, in data migration. For new ones, in function connected to post_save signal to Project model.

Karrp commented 5 years ago

@Karrp Could you say what task activities should be default for all projects or maybe talk about it with Adrian ? :)

@Szymiks If you create new project task activities should be None as default. Consequently when creating report employee should be able to chose every possible activity from list.

Karrp commented 5 years ago

Hmm it is quite edge case but we still need to handle this. What to do with reports which have activity which can be deleted by manager from list of project_activities?

We can do 2 things i think.

Not delete just inactive (not to choose in new reports -> edition? ) - more changes, need discussion
Delete and change to Other - easier but changes history

@kbeker what you think?

rwrzesien commented 5 years ago

@Szymiks Almost there, I think the one important thing left is passing task_activity_id in url and make proper html in the table.