Code-Poets / sheetstorm

Web working hours sheet for Code-Poets employees
https://www.sheetstorm.codepoets.it
2 stars 0 forks source link

Chore add default values to command generate test data #573

Closed marsolekk closed 3 years ago

marsolekk commented 4 years ago

There is a major change that needs to be made regarding usage of data sets - the command should have a singular parameter rather than four separate flags.

I didn't point it out previously, because I thought there might be a conscious design choice behind it, but yesterday I had an opportunity to discuss it with Remik and Karol and we're all on the same page here - data set option should be in a single parameter, like --data-size s/m/l/xl for example.

It makes much more sense logically and programatically, since we allow only one to be picked, therefore the set of flags must go. Remik made a great analogy to a radio button and a checkbox - parameter corresponds here with the first and flags with the latter.

This might take some effort to adjust the code, but it will also further simplify logic in your code, so it's a win-win +1 .

Done. I got rid of flags that you mentioned and add single parameter for data set size. I hope I applied it correctly.