search

Code-Pop / build-gmail-clone-with-vue-3

148 stars 136 forks source link

go[Newer/Older]AndArchive should not toggle archive, it should set to true #11

Open hafdon opened 3 years ago

hafdon commented 3 years ago

First, very good courses here, I really find them valuable.

In the course-end branch, in MailView.vue (starting video #10: Flexible Events) , you pass toggleArchive: true with goNewerAndArchive and goOlderAndArchive. However, those shouldn't toggle the archive value, they should set it to true.

https://github.com/Code-Pop/build-gmail-clone-with-vue-3/blob/course-end/src/components/MailView.vue#L29

hafdon commented 3 years ago

Oh I guess ... since you're only able to read un-archived emails then it's not a problem.