Code-Pop / watch-us-build-trello

271 stars 180 forks source link

I don't think MOVE_TASK code correct #26

Open areve opened 2 years ago

areve commented 2 years ago

https://github.com/Code-Pop/watch-us-build-trello/blob/a742aabbe723a26325cd4093116ccb0a3ce69211/src/store.js#L45-L48

This mutation doesn't affect the state at all, instead it modifies the arrays that are passed in as arguments. It works because the passed in values arrays happen to be the arrays from the store, but I don't think you're supposed to be modifying them directly.

Please discuss, I could be misunderstanding something.