Closed fulldecent closed 6 years ago
Thanks for setting this up. 👍
@jordangov Looks good, I see a bunch of commits just push, thought you wrote them earlier.
I know there's much to do on this project. But may I please ask for help with checkboxes on the top of this PR. Specifically I just wanted to know if stakeholders are identified -- not just you, the technical owner here, but the actual list of people that will sign off on launch. Also if any of those people have any specific requirements that must be met then it would be nice to identify them.
Anything on that list is my top priority so we can launch 1.0. Also if you can add any other hit list or breakers I'll be happy to contribute for sure.
I can understand your desire to have this nailed down, but that's a much more loose process within DDS. There will be a review, but it will mostly be on me to say I'm satisfied. I imagine @shawoods will want a review, and I'll have some other engineer(s) give it a technical review as well.
Understood. Thank you for that clarification. I have updated the original post with this information.
Sorry @fulldecent, but for now we're trying to keep that under wraps. We're only at internal review stage for now.
We'll open this up for wider review soon!
This PR will be merged into master
, not the GH pages branch. The deployment will not be to GH pages. We're very close here! Need to resolve some conflicts and we'll be (mostly) set.
@arichiv-usds The master
branch now requires a mandatory (approved) review before merging a PR. Can you please give this PR another once over and approve?
DO NOT MERGE just yet, waiting on the DNS to switch and propagate.
@jgarber623-gov I know you're sick today, but if you can review that would be awesome.
Hold the phone -- https://github.com/deptofdefense/code.mil/pull/146
:) Thanks @fulldecent. I'll merge those in.
Of course, there will always be more typos. Don't worry, this isn't a deploy-once-ignore-forever project!
My other last-minute change is #148. I have no more PRs coming today.
Get the bubbly ready.
Commented on that PR, it's going to need to wait until after launch - and after a design review.
And of course, there is one commit missing before hitting the button.
branch: static-site
But you get the honors on that one!
@fulldecent I think that's already updated in the travis yml file... or am I missing it elsewhere?
Yes, just saw it's good now. Ready to merge.
I think everything that needs to be addressed before merge is done. Waiting on the DNS switch to actually merge this bad boy.
What's this? http://www.code.mil
We're still working out some kinks... like code.mil not redirecting... and I need to update the s3 bucket because DNS. We're still in a holding pattern.
Our work in progress branch for the new code.mil website is currently in branch static-site. This pull request represents the initial launch of code.mil by pushing new code.
In the interest in actually launching, we will need to:
Launch is a beautiful thing, but it's not such a big deal. Once you are launched, it will attract more contributors that get you to where you really want to be!