search

Code-dot-mil / code.mil

An experiment in open source at the Department of Defense.
https://www.code.mil
MIT License
1.29k stars 126 forks source link

USWDS jekyll integration #128

Closed jordangov closed 6 years ago

jordangov commented 6 years ago

This PR pulls in the US Web Design Standards jekyll plugin and uses its config options for the header and footer. No real content changes here.

Thoughts welcome... I'll merge in a couple days if there's no comments. (Note: this is still a WIP and is not a deployed merge, just a merge into the WIP branch static-site.)

jgarber623-gov commented 6 years ago

Site builds fine locally without issues. 👍

jbjonesjr commented 6 years ago

Speaking of the USWDS theme, wanted to make sure you all saw this:

https://github.com/github/pages-gem/pull/495

This allows you to use the theme from it's remote host instead of having to manually add it to your site.

jordangov commented 6 years ago

That's neat! Looks like they have an issue with GH ("GitHub does not provide support for Jekyll Remote Theme")... not sure if that means GH pages or what. That said, having the theme locally, with a locked down version, actually helps with testing on local dev machines - for example while I'm programming without wifi (planes and such).

jbjonesjr commented 6 years ago

GitHub does not provide support support

Basically ben is just noting this is our early access, it's use at your own risk for the next few days before we genpop it. Plan is to make it available to all this calendar year.

:+1: to advantages of a local copy

jordangov commented 6 years ago

Ooooh... gotcha. Yeah... words matter. My bad.