search

Code-dot-mil / code.mil

An experiment in open source at the Department of Defense.
https://www.code.mil
MIT License
1.28k stars 122 forks source link

Simplify local build process #171

Closed arichiv-usds closed 6 years ago

arichiv-usds commented 6 years ago

cibuild -> build Now a one-stop-shop!

jgarber623-gov commented 6 years ago

@arichiv-usds Can you provide more details on the reason for this change?

It's not immediately clear why it'd be helpful to run gem update --system and bundle install every time a developer would run this build script locally. Is that script intended to be run by developers or only on CI?

arichiv-usds commented 6 years ago

@jgarber623-gov Sure!

I wanted to make a script that would work for CI (to ensure it doesn't break in future) and local dev (so someone with a fresh env could use it)

jordangov commented 6 years ago

@jgarber623-gov After taking out the system update I'm ok with this. I don't think running bundle install in the build harms anything (and makes things easier for people not familiar with Ruby dev).