search

Code-dot-mil / code.mil

An experiment in open source at the Department of Defense.
https://www.code.mil
MIT License
1.28k stars 122 forks source link

Simplify .travis.yml #205

Closed arichiv closed 6 years ago

arichiv commented 6 years ago

The dist, sudo, and env variables set here shouldn't be necessary

First part of #206

jordangov commented 6 years ago

I don't see how this ties to #206.

Why aren't the fields you're removing necessary? Can we get more explanation? If I recall, when we set this up things were failing without it. In particular, we had to add the NOKOGIRI_USE_SYSTEM_LIBRARIES=true for something very particular (I'd need to go back in the commit history or PR history to find it)... maybe @jgarber623-gov knows?

arichiv commented 6 years ago

The connection is just that this is cleanup before more changes. It looks like things are working?

jordangov commented 6 years ago

Can we wait for input from @jgarber623-gov ? I specifically remember us adding these things, but I also see that the CI build appears to be working... so... I dunno.