search

Code-dot-mil / code.mil

An experiment in open source at the Department of Defense.
https://www.code.mil
MIT License
1.28k stars 122 forks source link

Add screenshot to pull request #211

Closed arichiv closed 6 years ago

arichiv commented 6 years ago

This requires #210 and closes #206

arichiv-usds commented 6 years ago

64

arichiv-usds commented 6 years ago

66

jordangov commented 6 years ago

This is awesome, but it looks like it only got the header and hero elements in the screenshot? Can we not get the full page?

arichiv commented 6 years ago

@jordangov that is the entire page :-/

I'll look into the missing press section

Can I just make an issue against myself to add a real bot?

jordangov commented 6 years ago

I think we have a dds bot, maybe the creds in 1pass? We can use that token.

arichiv commented 6 years ago

@jordangov That login doesn't work, I want to push that issue into the future (e.g. next week) #212

jordangov commented 6 years ago

Dang... ok. Fine by me

jordangov commented 6 years ago

I still don't really understand why the screenshot thing isn't grabbing the whole page (footer as well).

arichiv commented 6 years ago

@jordangov it is grabbing the whole thing, check code.mil, the press section has disappeared somehow #213

jordangov commented 6 years ago

Oh shit! But it isn't grabbing the footer... sooo...