search

Code-dot-mil / code.mil

An experiment in open source at the Department of Defense.
https://www.code.mil
MIT License
1.29k stars 123 forks source link

Footer Email Reference #235

Open TangoYankee opened 6 years ago

TangoYankee commented 6 years ago

Feature

Increase maintainability of references in footer

Affected Area

footer, lines 58 & 59

Description

'href' for email uses a liquid reference to the configuration file. However, the associated 'text' is hard-coded. hard-coding could be replaced with: 

'{{site.email}}'
TangoYankee commented 6 years ago

Note this works for ruby version 2.3. It may break for 2.5

jordangov commented 6 years ago

Hey @TangoYankee ! Thanks for the report. I think I recall trying to do this at one point and it not working for some reason. That said, if it works, we should do it! PRs welcome. ;)

tinjaw commented 4 years ago

I believe this is resolved and should be closed? Is that true?

zacnomore commented 4 years ago

https://github.com/Code-dot-mil/code.mil/blob/e3060542de6125c6ba5a0f1c61c882b307330948/src/_data/footer.yml#L59

Agreed