Removed 'partners' as few other .json files had 'partners' in them.

mbermanarl commented 4 years ago

Thanks for submitting a pull request! Below are a few things you can do to help us more quickly review your changes.

Checklist

I have…

[x] run the application locally (./scripts/serve) and verified that my changes behave as expected.
[x] run the build process locally (./scripts/build) and make sure it builds correctly.
[x] run the test suite (./scripts/test) and verified that all tests pass.
[x] summarized below my changes and noted which issues (if any) this pull request fixes or addresses.
[ ] thoroughly outlined below the steps necessary to test my changes.
[ ] attached screenshots illustrating relevant behavior before and after my changes.
[ ] read, understand, and agree to the terms described in CONTRIBUTING.md.
[ ] added my name, email address, and copyright date to CONTRIBUTORS.md.

Summary of Changes

This pull request…

Summarize change number one.
Summarize change number two.
etc. etc. etc.

Testing

To verify the changes proposed in this pull request…

Describe testing step one.
Describe testing step two.
etc. etc. etc.

Screenshots

Attach relevant before and after screenshots here.

jordangov commented 4 years ago

Heh... fun story, I have a separate PR in for this field because it doesn't follow the proper code.gov format. Would you rather fix it or remove it?

mbermanarl commented 4 years ago

May as well remove it to be consistent with all the other projects. I don't have email addresses for the organizations either.

-Morris Berman (morris.s.berman.civ@mail.mil)

Morris Berman (301)394-4188 (V, ALC) (301)873-7975 (Mobile) (301)394-1801 (FAX)

U.S. Army Research Laboratory ATTN: FCDD-RLS-DP (Power Conditioning Branch) (Morris Berman) 2800 Powder Mill Road
Adelphi, Maryland 20783-1145

-----Original Message----- From: Jordan Kasper notifications@github.com Sent: Wednesday, November 13, 2019 10:11 AM To: Code-dot-mil/code.mil code.mil@noreply.github.com Cc: Berman, Morris S CIV USARMY FUTURES COMMAND (USA) morris.s.berman.civ@mail.mil; Author author@noreply.github.com Subject: [Non-DoD Source] Re: [Code-dot-mil/code.mil] Removed 'partners' as few other .json files had 'partners' in them. (#259)

All active links contained in this email were disabled. Please verify the identity of the sender, and confirm the authenticity of all links contained within the message prior to copying and pasting the address to a Web browser.

Heh... fun story, I have a separate PR in for this field because it doesn't follow the proper code.gov format. Would you rather fix it or remove it?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < Caution-https://github.com/Code-dot-mil/code.mil/pull/259?email_source=notifications&email_token=ANJNMNQWIA45UZ2JXEUVGMDQTQKILA5CNFSM4JM4VQTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED6ORBQ#issuecomment-553445510 > , or unsubscribe < Caution-https://github.com/notifications/unsubscribe-auth/ANJNMNQRZQ3TW57R2MIDKJTQTQKILANCNFSM4JM4VQTA > . <Caution-https://github.com/notifications/beacon/ANJNMNS6RX46HUC6VBDQCZLQTQKILA5CNFSM4JM4VQTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED6ORBQ.gif>

jordangov commented 4 years ago

Don't worry about consistency, be a trend setter! The field exists in the schema for a reason. :)

That said, happy to remove it if you want.

mbermanarl commented 4 years ago

I don't want to be the nail that sticks up and gets hammered back down! :-) I'm good with removal.

-Morris Berman (morris.s.berman.civ@mail.mil)

Morris Berman (301)394-4188 (V, ALC) (301)873-7975 (Mobile) (301)394-1801 (FAX)

U.S. Army Research Laboratory ATTN: FCDD-RLS-DP (Power Conditioning Branch) (Morris Berman) 2800 Powder Mill Road
Adelphi, Maryland 20783-1145

-----Original Message----- From: Jordan Kasper notifications@github.com Sent: Wednesday, November 13, 2019 10:20 AM To: Code-dot-mil/code.mil code.mil@noreply.github.com Cc: Berman, Morris S CIV USARMY FUTURES COMMAND (USA) morris.s.berman.civ@mail.mil; Author author@noreply.github.com Subject: [Non-DoD Source] Re: [Code-dot-mil/code.mil] Removed 'partners' as few other .json files had 'partners' in them. (#259)

All active links contained in this email were disabled. Please verify the identity of the sender, and confirm the authenticity of all links contained within the message prior to copying and pasting the address to a Web browser.

Don't worry about consistency, be a trend setter! The field exists in the schema for a reason. :)

That said, happy to remove it if you want.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < Caution-https://github.com/Code-dot-mil/code.mil/pull/259?email_source=notifications&email_token=ANJNMNXRWQXS5I3DPIL7OP3QTQLLFA5CNFSM4JM4VQTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED6PRLY#issuecomment-553449647 > , or unsubscribe < Caution-https://github.com/notifications/unsubscribe-auth/ANJNMNTOGDVNRM3HREJ3RELQTQLLFANCNFSM4JM4VQTA > . <Caution-https://github.com/notifications/beacon/ANJNMNVIJAM6HKY6DE6MGY3QTQLLFA5CNFSM4JM4VQTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED6PRLY.gif>

Code-dot-mil / code.mil