Code-dot-mil / code.mil

An experiment in open source at the Department of Defense.
https://www.code.mil
MIT License
1.28k stars 121 forks source link

changed hardcoded email text to site reference [issue #235] #260

Closed Brorean closed 4 years ago

Brorean commented 4 years ago

In the site footer changed hardcoded email text to a variable site.email. This is for issue #235.

jordangov commented 4 years ago

Thanks @Brorean ! We appreciate the PR. We'll need to have you sign the CONTRIBUTORS.md file before we can accept the PR, and we do have a PR template that seems to have gotten lost here. Can you please pull that in and check of the items as you've completed them?

I know this is a small change, but we're trying to make sure we can have a solid process for all contributions.

Brorean commented 4 years ago

Checklist

I have…

Summary of Changes

Changed the site footer to use site.email instead of hard coded value.

Testing

Start server using ./scripts/serve and open in web browser. Scroll to the footer in the page and verify that the code@dds.mil email address appears. Click on page and view source. Scroll to the footer and verify that the reference uses {{site.email}}.

Screenshots

Before: Screenshot from 2019-11-15 10-31-02

After: Footer html

Footer on main page

jordangov commented 4 years ago

Thank you so much! Really appreciate the effort, and feel free to hack on anything else ;)