Fixed the HTML proofer - Githubissues

Code-dot-mil / code.mil

An experiment in open source at the Department of Defense.

https://www.code.mil

MIT License

1.28k stars 121 forks source link

Fixed the HTML proofer #261

Closed jordangov closed 4 years ago

jordangov commented 4 years ago

Checklist

I have…

[x] run the application locally (./scripts/serve) and verified that my changes behave as expected.
[x] run the build process locally (./scripts/build) and make sure it builds correctly.
[x] run the test suite (./scripts/test) and verified that all tests pass.
[x] summarized below my changes and noted which issues (if any) this pull request fixes or addresses.
[x] thoroughly outlined below the steps necessary to test my changes.

Summary of Changes

Fixed the HTML proofer to properly ignore the 2 urls that we know are good, but keep failing our tests.

Testing

To verify the changes proposed in this pull request just run the test script: ./scripts/test

jordangov commented 4 years ago

Approving my own PR... I know, I'm a monster.