search

Code-the-Dream-School / school-pages

static content for CTD students
https://school-pages.codethedream.org/
4 stars 6 forks source link

feat: support for mermaid #65

Closed jdevries3133 closed 11 months ago

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
school-pages ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2023 9:08pm
jdevries3133 commented 1 year ago

I did notice that mermaid charts can get weird on small screen sizes. I think I might like to merge that and leave this as an area for future improvement, though, unless you happen to know of a quick fix off-hand.

royemosby commented 1 year ago

With all these compounded challenges and the fact that you have to patch the package to get it operable, we should probably demote it to "nice to have". I'm invested in the notion of eventually using Mermaid so we can keep this around so we can revisit later.

royemosby commented 1 year ago

https://github.com/Code-the-Dream-School/school-pages/pull/65#issuecomment-1575197125

I see that and I think the mobile rendering really messes any chance of using it for now :-(