search

Code2Gether-Discord / JokesOnYou

A learning project, A jokes website build as a team project.
12 stars 11 forks source link

Add liking and unliking tag functionality #194

Closed JunXingLiu closed 2 years ago

JunXingLiu commented 2 years ago

The model LikedTags should imo be renamed to LikeForTag. Its not a LikedTags (the s making it multiple) anymore. So there should be some more changes all over but just the name. and also controller names and stuff. @chrisK00 what do you think ?

Should I change it for Repo and Services? from LikedTagsRepository -> LikedTagRepository

HellHunterMax commented 2 years ago

The model LikedTags should imo be renamed to LikeForTag. Its not a LikedTags (the s making it multiple) anymore. So there should be some more changes all over but just the name. and also controller names and stuff. @chrisK00 what do you think ?

Should I change it for Repo and Services? from LikedTagsRepository -> LikedTagRepository

Repo, services, controller and model. LikeForTagsRepository in my opinion... and change the model to a LikeForTag so then everything is named the same way.

JunXingLiu commented 2 years ago

The model LikedTags should imo be renamed to LikeForTag. Its not a LikedTags (the s making it multiple) anymore. So there should be some more changes all over but just the name. and also controller names and stuff. @chrisK00 what do you think ?

Should I change it for Repo and Services? from LikedTagsRepository -> LikedTagRepository

Repo, services, controller and model. LikeForTagsRepository in my opinion... and change the model to a LikeForTag so then everything is named the same way.

I changed it. Hmm should the DB table be changed as well or that can remain?

HellHunterMax commented 2 years ago

The model LikedTags should imo be renamed to LikeForTag. Its not a LikedTags (the s making it multiple) anymore. So there should be some more changes all over but just the name. and also controller names and stuff. @chrisK00 what do you think ?

Should I change it for Repo and Services? from LikedTagsRepository -> LikedTagRepository

Repo, services, controller and model. LikeForTagsRepository in my opinion... and change the model to a LikeForTag so then everything is named the same way.

I changed it. Hmm should the DB table be changed as well or that can remain?

Yes the database table name should be the same as the model.

JunXingLiu commented 2 years ago

The model LikedTags should imo be renamed to LikeForTag. Its not a LikedTags (the s making it multiple) anymore. So there should be some more changes all over but just the name. and also controller names and stuff. @chrisK00 what do you think ?

Should I change it for Repo and Services? from LikedTagsRepository -> LikedTagRepository

Repo, services, controller and model. LikeForTagsRepository in my opinion... and change the model to a LikeForTag so then everything is named the same way.

I changed it. Hmm should the DB table be changed as well or that can remain?

Yes the database table name should be the same as the model.

Done!

HellHunterMax commented 2 years ago

I just created the UserJokeTag that is actually needed for this issue. Please review #207 Then we can edit this one to use UserJokeTag for liking.

JunXingLiu commented 2 years ago

I just created the UserJokeTag that is actually needed for this issue. Please review #207 Then we can edit this one to use UserJokeTag for liking.

Should I modify my code so it uses UserJokeTag? or that is another issue?

HellHunterMax commented 2 years ago

Yes that would be best imo I'll merge to dev.

JunXingLiu commented 2 years ago

Yes that would be best imo I'll merge to dev.

I think I got it working. Please take a look.

HellHunterMax commented 2 years ago

I see I still had some unpushed comments ready. You could fix those as well if you want to make it complete.

JunXingLiu commented 2 years ago

I see I still had some unpushed comments ready. You could fix those as well if you want to make it complete.

I'll get those out of the way