search

Code4Community / platformer

MIT License
0 stars 2 forks source link

Refactor map and camera setup to ECSScene class #16

Closed jayeclark closed 2 years ago

jayeclark commented 2 years ago

Signed-off-by: Jay Clark jay@jayeclark.dev

Fixes #13

Hi there! I came across this issue and although it was in "In Progress", it didn't look like anyone was working on it, so I thought I'd take a shot at a fix. The only thing I wasn't certain of was whether the world and camera bounds would be likely to be different for different scenes. (It seemed like the answer was no, but if not let me know and I can adjust the PR!)

Tass0sm commented 2 years ago

This is good work and worth merging. Unfortunately, this is a learning project for students in the Code4Community club at OSU, and a student is working on this issue in the MapSetup branch. Good luck on your future open source work!

jayeclark commented 2 years ago

Please consider adding clear information to that effect in your readme and getting started guides.

Tass0sm commented 2 years ago

I have now merged this (36b0ca08181b646275f4fe9786bbab3bee74c7b0) into the MapSetup branch.

jayeclark commented 2 years ago

Thanks, I appreciate the merge and hope my suggestions are helpful to whoever is working on the issue.

In case my last message came across the wrong way, it's perfectly fine to have an open source project be restricted to certain types of contributors, and I certainly don't want to step on any toes or take away someone's learning opportunity.

I should have reached out to verify that the In Progress tag meant someone was still actively working on the issue even though no one was assigned. However, a line in the readme also would be very helpful in discouraging random non-OSU contributions.