Code4GovTech / server

0 stars 4 forks source link

Credentials V2 #164

Open karntrehan opened 1 week ago

karntrehan commented 1 week ago

Requirements:

To do:

KDwevedi commented 1 week ago

Service Design

C4GT BFF Redesign drawio

DB Requirement: To map templates to verified templates. Since this is expected to be an extremely small dataset, a minimal db for this can be discussed.

API Design

/schema APIs

/template APIs

/certificate APIs

Example of puppeteerConfig:

{
  "height": 1130.67,
  "width": 760,
  "scale": 1.33,
  "landscape": true,
  "displayHeaderFooter": false,
  "printBackground": true
}

Note: The puppeteerConfig parameter allows overriding default settings, such as height, width, scale, landscape orientation, and more, giving flexibility for fine-tuning during template iteration.

/rcw/verify/{credentialID} API

karntrehan commented 1 week ago

Great work @KDwevedi !

Just some suggestions:

Also, what would be the ETA of this implementation? Would be good to have visibility on that as well.

KDwevedi commented 1 week ago

Since we're aiming for swagger to be our UI, we can do basic auth using a password, other methods would require the user to juggle API responses with various auth tokens

KDwevedi commented 1 week ago

@karntrehan I should be able to deliver on the updated APIs in 2 days time, having a PR ready for review with code modifications, swagger setup, and basic tests by Thursday noon.

jaanbaaz commented 5 days ago

@KDwevedi can you pls share an update here?

AbhimanyuSamagra commented 4 days ago

@KDwevedi to finish this by 22nd November - @MohitNSamagra to check with him again

AbhimanyuSamagra commented 2 days ago

Ready by 22nd November - update to be given on the 22nd standup