Code4GovTech / server

0 stars 4 forks source link

[C4GT classroom] Check classroom points on supabase #66

Closed omkar309 closed 4 months ago

omkar309 commented 6 months ago

Requirement: It has been noticed that the points of contributors present on GitHub classroom is in different than the points stored in our supabase table. @sasi2312 to check once if the points visible using GitHub classroom API are the same as stored in our supabase table.

Reason: To avoid any data discrepancy.

List of contributors who're not able to see their names on the community leaderboard or the no. of their DPG points shown is incorrect: https://docs.google.com/spreadsheets/d/1YxMSWc_u7wIJ0T15o0y30QngCEL7ASO4FPWuuA0RIco/edit?usp=sharing

karntrehan commented 5 months ago

Github API is failing - 500. Was working fine previously. @sasi2312 to check.

MohitNSamagra commented 5 months ago
sasi2312 commented 5 months ago

I have tried with this endpoint https://api.github.com/assignments/{id}/accepted_assignments ---- it working.

MohitNSamagra commented 5 months ago
sasi2312 commented 5 months ago

These user have grade as NULL: @MohitNSamagra @KDwevedi

We getting 30 assignments in Github api resposnes:

  1. 22 records are already exists in github_classroom_data
  2. 8 records not exists in that

Not exist records:

These users are not exists in contributors_registration as well

KDwevedi commented 5 months ago

@sasi2312 Can you edit the above comment and add the total count of individual assigments that you're getting?

karntrehan commented 5 months ago

Null mapped to 0. @MohitNSamagra to check and confirm.

MohitNSamagra commented 5 months ago
MohitNSamagra commented 5 months ago
karntrehan commented 5 months ago

Complaints checked. Found 49 complaints where classroom is completed, but DPG points are less than 100.

@karntrehan to discuss with Yash / Chakshu on this.

MohitNSamagra commented 5 months ago
MohitNSamagra commented 5 months ago
karntrehan commented 5 months ago

Flow:

  1. User lands on classroom link
  2. Enrolls for classroom
  3. Repo with format stylusdb-sql-assignment-$user_name gets created under https://github.com/status-20X org.
  4. Github API tells us grading for each of these repos through github actions.

Total forks: 1.7K Forks visible in status-20X org: 1.4K

Issues:

  1. In the video shared we have asked folks to transfer ownership of the created repo to their profile. These transferred repos' grading is not exposed to us by github. Impact: 108/1.7K (7.7%)
  2. Contributors are forking the above created repositories to their profiles. This can be ignored. Impact: 41/1.4K (2.9%).

Solutions:

  1. Upload corrected video which cuts at 7:03 (before asking people to transfer ownership).
  2. Make 108 users contributors in status-20X org. Ask them to transfer repo to status-20X org from their profile. Users to re-run autograding on these transferred back repos. (Validated with 1 CL account already - huzaifmalik786)
MohitNSamagra commented 5 months ago
karntrehan commented 5 months ago

PT confirmed that fix is working. No further issues. Certificate generation pending on @KDwevedi + @karntrehan

MohitNSamagra commented 4 months ago