Code4HR / hrt-bus-finder

Web app for the HRT bus API, GitHub Pages, @bschoenfeld and @wbprice
hrtb.us
16 stars 33 forks source link

New Years Bug #196

Closed bschoenfeld closed 6 years ago

bschoenfeld commented 7 years ago

The backend has trouble handling year changes. It has to figure out which year each checkin from HRT is in since HRT only includes the month, day, and time. There are some boundary case issues that cause the code to create checkins in the wrong year (usually one year ahead) and these checkins get stuck in the database and break the app.

qwo commented 6 years ago

@bschoenfeld I think you closed this with https://github.com/Code4HR/hrt-bus-api/commit/b66a10e5942ea5319ac966e9128d6ccd7a94dc2a

bschoenfeld commented 6 years ago

Yes. Good catch.

bschoenfeld commented 6 years ago

The actual commit is https://github.com/Code4HR/hrt-bus-api/commit/32fe813868f83a21edd32bc77b10bd5d9e944d1a