search

Code4HR / local-art-api

Public Art Installations in Norfolk, VA
https://localartapi-code4hr.rhcloud.com/
GNU Affero General Public License v3.0
4 stars 4 forks source link

Hapi Rewrite #27

Closed wbprice closed 9 years ago

wbprice commented 9 years ago

To start, use Overpass API to get all the data in a bounding box.

ghost commented 9 years ago

Looks good, just need to add the license file back.

We decided at Stella's to use Affero since we don't know if this would go over 300 lines, so I'll change that and you can merge that change in if you like before we merge this request.

wbprice commented 9 years ago

@ryayak1460 I added the Affero license and pushed up that commit.

qwo commented 9 years ago

:+1: rebase needed

ghost commented 9 years ago

Only one thing: we need to return exhibits without requiring a query parameter. Ember.js will want to use the /exhibits route like a model call, so we can't include a bounding box in the request. I forgot about that part, sorry.

Past that, dude, @wbprice: awesome work. OpenShift, Hapi.js rewrite, functional code and Affero? Hell yeah!

wbprice commented 9 years ago

@ryayak1460 what should a call to /exhibits without any querystring return?

ghost commented 9 years ago

All exhibits.

On 13 January 2015 08:51:14 GMT-05:00, "W. Blaine Price" notifications@github.com wrote:

@ryayak1460 what should a call to /exhibits without any querystring return?

Reply to this email directly or view it on GitHub: https://github.com/Code4HR/local-art-api/pull/27#issuecomment-69746293

Sent from my Android device with K-9 Mail. Please excuse my brevity.

wbprice commented 9 years ago

@ryayak1460 That can be done, but my concern is the the app won't scale well if we're not limiting response size. This person does something with query strings: http://stackoverflow.com/questions/16506634/ember-route-with-dynamic-filter-search-criterias