basic implementation of trisha design #8

[qwo]

Feel free to edit/change hack on it.

written with responsiveness in mind using purecss which is just some sugar ontop of normalize css.

http://purecss.io/

[ghost]

Hey, sorry about the lack of response to this so far, had the Bitcoin and Ruby meetups last night, I will try and take a look at this maybe tomorrow night or Sunday. I tried to comment last night, but I had huge layout/display issues on Firefox last night. Tried posting a screencap, but my computer died in the process of doing so.

It may need some work at first, not to mention it does look a little strange on desktop, with everything so huge, especially in the List view. How can we make this change apply only to mobile devices? Could we do that using media queries? I know so little about them.

[ghost]

Okay, so far, everything looks pretty solid on Windows Firefox. Here's a screenshot (or two):

I'll have to test with Iceweasel, Firefox for Android and the like later tonight. If anyone wants to test IE, Chrome, Safari and Opera, please do.

My only request past the line comments for the files changed: please follow the JavaScript Web Labels guide to include PureCSS as a dependency in #/about/javascript. Easy stuff, but helpful for license compliance.

[qwo]

Wow Ryan, you did a real hard review to all the changes. Really appreciate it!

Let me answer the top of my head some of your questions

Which editor

Atom Editor, I use a plugin that kills excess whitespace on save so theres some diffs to any file i touch. The license has some white spaces on each file :\

IE specific Code ewww

yeah i dont really care for ie. I dont believe i even linked in the backup files so it would even work.

PureCSS is using normalize css 1.2 which supports ie6 and up, normalize is actually currently at version 3+ and already in ember which is cool so i override the stock normalize in the library.

Anyway I intend to remove this code

Beautiful nesting

Sorry about that, I was trying to clean it up so it was more bunched in the source view. It does look cleaner in the editor but messy in source on page.

Adding licensing to editor

forgot to! but fully will mean to do so

name of css label for js license

I think this was already there and i was trying to adhere to the convention set. I'm happy to rip it out, I dont think its doing anything not already handled anymore.

Thanks ryan again for the loookover. If @aimsrandom and @aureately wants to take a look at the screen caps and see what kind of improvements we should make go for it. Totally open on hacking it up.

Some suggestions I've gotten include

• Use icons in conjunction with words on the bottom page
• Paginate list views on view
• provide a way for user to jump back to the position they were in the listing
• add walking tour capability.

This is still pretty much v.01 but it gives us a more solid grounding.

I intend to work on it till a slow v.1 but divert effort to helping @bschoenfeld integrate localwiki + art app to create art walking tour app powered by local wiki. That is the 1.0 milestone to shoot for!

I need to look at the api but i definitely think its possible and would require very little fiddling

[qwo]

@ryayak1460 check the commit messages as I've added them to correspond with your issues.

I think I got all of them.

As for the Javascript licensing, PureCSS is BSD licensed so its fine, but it is also pureCSS, which i dont think i should add to about/js. Otherwise i added it to the tech page so let me know if thats satisfactory.

Let me know if i missed something

[ghost]

Before I look it all over: yeah, that actually makes sense regarding PureCSS. Just used to any frontend libraries using JavaScript. :smile:

We don't use them in a minified sense, though, right?

[ghost]

Here's the latest Iceweasel visuals on Debian:

Map:

List:

Exhibit:

About:

Licenses:

It seems like the CSS aligns them vertically instead of horizontally for some reason. I wonder if we could possibly correct that?

Also, can't post Android screenshots at the moment because all technology except Node hates me right now, especially my phone and the hacktop.

[ghost]

So basically, barring weird visuals on mobile and the existing Linux visual discrepancies, most of the code comments and/or complaints I have relate to whitespace formatting, so pretty sure we could even commit this now and have no real problems.

I'll wait first to see if you have any ideas regarding the Debian Iceweasel discrepancies first and to see if anyone can post Android and iOS screenshots first, but after we can just merge this and get more advice from @aimsrandom, @jalbertbowden and possibly @aureately if she still has interest in any design work for this project.

[ghost]

I wrote a contributing guide here for future changes.

[ghost]

Seems like the line comments always show on the last line of the block shown here on the pull request. If the line comment doesn't make sense, I would look at the last line.

[ghost]

Sidenote regarding the List view: we should have some delimiter between the exhibit title and its location. Currently the last title word and the first location word mash together.

[ghost]

Also, why do the artists and location centre in the detail view, but the image and description don't, at least the header for the section?

[ghost]

Everything else looks great so far, at least on Windows. I think the current stable Iceweasel on Debian 7.5 bases off of Firefox 23 or 27 or the like... I'll have to check. Maybe that can help with the style deviations. I can provide the hacktop for visual testing at the next hack night, if you prefer.