search

Code4HR / open-health-inspection-scraper

Scraper for the open-health-inspector app.
Apache License 2.0
7 stars 9 forks source link

New Branch for SmartyStreets? #11

Closed ttavenner closed 10 years ago

ttavenner commented 10 years ago

I'm planning to implement SmartyStreets, now that we have it, rather than Google. Should I create a separate branch for SmartyStreets and keep the Google API version? It would make the code more accessible since not everyone will have SmartyStreets access but everyone will have Google access.

bschoenfeld commented 10 years ago

Create a branch off master now called google geocoding or some such and then do smarty streets on master.

On Sunday, May 4, 2014, Tommy Tavenner notifications@github.com wrote:

I'm planning to implement SmartyStreets, now that we have it, rather than Google. Should I create a separate branch for SmartyStreets and keep the Google API version? It would make the code more accessible since not everyone will have SmartyStreets access but everyone will have Google access.

— Reply to this email directly or view it on GitHubhttps://github.com/c4hrva/open-health-inspection-scraper/issues/11 .

bschoenfeld commented 10 years ago

Or better yet just tag the last commit before you start smarty streets. We probably won't continue to support the google geocoding branch.

On Sunday, May 4, 2014, Ben Schoenfeld ben.schoenfeld@gmail.com wrote:

Create a branch off master now called google geocoding or some such and then do smarty streets on master.

On Sunday, May 4, 2014, Tommy Tavenner notifications@github.com<javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

I'm planning to implement SmartyStreets, now that we have it, rather than Google. Should I create a separate branch for SmartyStreets and keep the Google API version? It would make the code more accessible since not everyone will have SmartyStreets access but everyone will have Google access.

— Reply to this email directly or view it on GitHubhttps://github.com/c4hrva/open-health-inspection-scraper/issues/11 .

ttavenner commented 10 years ago

Good thought. Done.