search

Code52 / DownmarkerWPF

MarkPad - a visual Markdown editor (inspired by the Downmarker project)
http://code52.org/DownmarkerWPF/
Microsoft Public License
1.4k stars 458 forks source link

Awesomium + Win8.1 Preview = *Almost Works* #390

Closed shiftkey closed 11 years ago

shiftkey commented 11 years ago

image

Investigating whether anything upstream has been reported sigh

shiftkey commented 11 years ago

Minor update 1.7.1.0 is available, let's see if it makes a difference...

shiftkey commented 11 years ago

Looks good, let me open a PR and polish it off

image

distantcam commented 11 years ago

Is it worth switching to cefsharp?

shiftkey commented 11 years ago

No clue. This seems to be an easy change to make for now.

I haven't had a chance to dig into the various non-English character issues we've got in the backlog - seems to be some rendering issues in there which might give us incentive to look at CefSharp.

distantcam commented 11 years ago

Yeah sorry I meant switching in general, not right now just to fix this bug.

I was planning to look into it this weekend, but got consumed by another OSS project.

JakeGinnivan commented 11 years ago

@distantcam I did the work a while back to pull the preview into it's own project, and it is fully isolated. So it may be worth spiking out. If cefsharp does a better job of staying off the UI thread when starting we may be able to get rid of all the preview appdomain stuff.

@shiftkey that sort of UI issues could be caused by the preview being hosted in another appdomain, then using window handles to essentially render it on the main appdomain. Maybe something has changed in windows 8.1 around this. My internet connection at this hotel is pretty lousy, so is taking ages to clone thing (but the fact it allows ssh is a good start :))

distantcam commented 11 years ago

@JakeGinnivan That's exactly why I want to try cefsharp. If it works better then we no longer have to do that appdomain hackery.

shiftkey commented 11 years ago

@distantcam make it so

@JakeGinnivan see #391 for the "works on my machine" fixes