Code52 / DownmarkerWPF

MarkPad - a visual Markdown editor (inspired by the Downmarker project)

http://code52.org/DownmarkerWPF/

Microsoft Public License

1.4k stars 460 forks source link

CefSharp replacing Awesomium #393

Closed distantcam closed 11 years ago

distantcam commented 11 years ago

TODO

[x] Swap native binaries
[x] Replace control
~~[ ] Remove font size/zoom as it's not supported by CefSharp~~
[x] Synchronize document scroll with preview scroll
[x] Support themes
[x] Styling
[x] Add new binaries to ClickOnce scripts
Pros
Control works without needing AppDomain jiggery pokery
Easier to support
One less assembly
Can now print again
Cons
Lost the ability to zoom the font. If needed could be replaced with WPF scaling.

JakeGinnivan commented 11 years ago

Could the zooming be done using a dynamic style sheet which is provided by code?

JakeGinnivan commented 11 years ago

Also the clickonce scripts will need to be updated, there are powershell scripts which update the manifest for native files.

JakeGinnivan commented 11 years ago

Looking good :+1:

distantcam commented 11 years ago

Could the zooming be done using a dynamic style sheet which is provided by code?

Possibly! I lack the web skillz to do that, if someone else want's to do it that way.

Thanks for reminding me about clickonce. I'll add it to the todo.

JakeGinnivan commented 11 years ago

If i get the chance, ill submit a PR to your branch to try and get zooming working.

Sent from my Windows Phone

From: Cameron MacFarlandmailto:notifications@github.com Sent: ý14/ý07/ý2013 07:46 To: Code52/DownmarkerWPFmailto:DownmarkerWPF@noreply.github.com Cc: Jake Ginnivanmailto:Jake.Ginnivan@readify.net Subject: Re: [DownmarkerWPF] CefSharp replacing Awesomium (#393)

Could the zooming be done using a dynamic style sheet which is provided by code?

Possibly! I lack the web skillz to do that, if someone else want's to do it that way.

Thanks for reminding me about clickonce. I'll add it to the todo.

— Reply to this email directly or view it on GitHubhttps://github.com/Code52/DownmarkerWPF/pull/393#issuecomment-20932542.

distantcam commented 11 years ago

@JakeGinnivan No rush. If you don't get it done before this PR goes in you can always add it later.

I'm pretty sure I won't get to work on this again till next weekend anyway.

distantcam commented 11 years ago

I've finished everything except the font zoom. @JakeGinnivan I'm happy to have that done in another PR and close this one.

Code52 / DownmarkerWPF

CefSharp replacing Awesomium #393

TODO

Pros

Cons