Removing Plugins - Githubissues

Code52 / DownmarkerWPF

MarkPad - a visual Markdown editor (inspired by the Downmarker project)

http://code52.org/DownmarkerWPF/

Microsoft Public License

1.4k stars 460 forks source link

Removing Plugins #396

Open distantcam opened 11 years ago

distantcam commented 11 years ago

Does anyone have objections if I remove the plugins?

I'll fold the only plugin we have into the main code.

I don't like plugins because:

The plugin API has to be versioned. This is a pain, especially if you want to support backwards compatibility.
Plugins are either run in the same app-domain, or in their own app-domain so as to not cause the whole app to crash. In either case handling a crashing plugin needs work.
When a plugin crashes, the main app gets blamed.
How are plugins installed? If we're using clickonce how would that work?

Thoughs? @JakeGinnivan @shiftkey

JakeGinnivan commented 11 years ago

Yeah, happy to drop them. I still like separation of concerns etc, so we can still have IEnumerable<IRenderTransformer> etc, but not as a plugin model

distantcam commented 11 years ago

I still like separation of concerns etc, so we can still have IEnumerable<IRenderTransformer> etc, but not as a plugin model

Why? Separation of concerns is nice and all, but why add it to the render transforms? How do you handle order and dependencies?

Again, KISS and avoid unnecessary complexity.

JakeGinnivan commented 11 years ago

Doesn't have to be that abstraction.

I'm just saying it was a bitch pulling the DocumentViewModel apart because it had the entire applications logic in it. Happy for them to be moved into application services or something

shiftkey commented 11 years ago

I'll fold the only plugin we have into the main code.

:+1:

If it's unused code or abstractions, let's kill it off.

I'm just saying it was a bitch pulling the DocumentViewModel apart because it had the entire applications logic in it. Happy for them to be moved into application services or something

Is this worth a separate discussion?