search

Code52 / carnac

A utility to give some insight into how you use your keyboard
http://carnackeys.com/
Microsoft Public License
4.18k stars 505 forks source link

Inform user a restart is required for update settings, or refresh settings after Save #267

Open HowardWolosky opened 4 years ago

HowardWolosky commented 4 years ago

I just started trying out Carnac today and tried to change the fadeout delay, but it didn't work. I searched through the issues/PR's and came across this comment from #133:

Just one minor thing, changing the value requires a restart of the app, but I guess there's not much we can do about that as the settings are read at startup?

From an end-user perspective, I just figured the feature was broken.

I see three potential ways to improve the experience for the end-user:

  1. Add a note at the top of the settings page that says something to the effect: "Any changes made will require a restart of the app to take effect."
  2. When clicking Save, have a pop-up of some sort say: "A restart of the app is required for these changes to take effect." 2b. In that pop-up have a button that offers to restart the app for the user (a la VS Code after an update).
  3. Refactor the settings logic so that it can be updated dynamically after the user hits Save so that it just works.
AaronLLTT commented 2 years ago

This should definitely be done. The third option is the best, but probably the most time consuming. Option 2 is vital, as I was just trying this app and about to dismiss it as garbage until I found this post.

vishnuvardhan-s commented 1 year ago

I agree on point 2. I also thought it was a bug or some missing deps and later saw this comment by searching through Issues/PRs.