search

Code52 / pretzel

A site generation tool (and then some) for .NET platforms
http://code52.org/pretzel/
Microsoft Public License
595 stars 163 forks source link

Link parsing in latest version #236

Closed dkarzon closed 9 years ago

dkarzon commented 9 years ago

After updating to the latest version (previously on a build from over a year ago) I am having an issue with link parsing. Not sure if it's a problem with Pretzel or dotliquid and it doesn't seem to affect all links on the page, only certain ones. Currently using v0.2.1.127 from AppVeyor, older version doesn't have a proper version in the file properties.

This is the html in my post

<a href="https://www.jetbrains.com/teamcity/">Team City</a>

And this is what gets outputted by Pretzel

<a href="a%20href=%22https://www.jetbrains.com/teamcity/%22">a href=&quot;https://www.jetbrains.com/teamcity/&quot;</a>Team City</a>

Here is a quick sample to show the problem, simple layout structure and a single post. https://www.dropbox.com/s/lmpvx9ktigqc2p6/PretzelTest.zip?dl=0

laedit commented 9 years ago

Nice catch, I will look into that. Does this occurs only with the links in the first paragraph?

dkarzon commented 9 years ago

In that sample yes, I did have it happen in other places on different posts. At the moment my fix for it was to wrap the first paragraph in a <p>

laedit commented 9 years ago

Quick fix: since you doesn't use markdown but pure html, just change the extension of your post file to html. I think the problem comes from the change of markdown engine but I haven't got the time to verify it.

laedit commented 9 years ago

I can confirm that it's coming from the new markdown engine, but I don't consider it a bug: your file is an html one and so had to have the html extension and not md since it has no interest to be transformed from markdown to html.

But will you be interested by the possibility of changing the markdown engine? Since your are not the only one (#237) I think it's something that we can add.

dkarzon commented 9 years ago

@laedit I just tested this with the latest version of CommonMark.NET and the issue is gone. See the commit with the fix https://github.com/Knagis/CommonMark.NET/commit/99c0d7e8adcd6fb288a176d2ee22e9faac369ca8

PR submited.