search

CodeAG / LLadders

Ladders!
http://ladders.luppii.se/
Other
0 stars 4 forks source link

Mod support: Carpenter's Blocks #23

Closed holmsten closed 9 years ago

holmsten commented 10 years ago

Maybe you could make Carpenter's Ladders come out of the Ladder Dispenser?

-Cheeyev @ http://www.minecraftforum.net/forums/mapping-and-modding/minecraft-mods/1294764-luppiis-ladders?comment=71

holmsten commented 10 years ago

This is a genuinely good suggestion as the Carpenter's Blocks do look good. AFAIK the ladders only bring another texture/model to the Minecraft ladders and not any new functionality, which means new logic has to be made to support Minecraft ladders.

Mod support for Carpenter's blocks is also good for a future "Fence Dispenser" (old idea - can't find an issue for it though).

holmsten commented 10 years ago

On hold until #7 is done.

aiqueneldar commented 9 years ago

I am done with my issues. Looking into this in sepparate branch.

aiqueneldar commented 9 years ago

I've looked into this and found some problems and some questions that we need to consider and decide:

  1. I re-wrote a lot of the code to rely on out Ladders. This means just the dispenser code needs major refactoring to work with Carpenter Ladders. It is in no way impossible, but a lot of work.
  2. Carpenters ladders are place in the center of a block. Making them only have 2 facing directions. And won't be compatible with our ladders while climbing up from ours to carpenter ladder.
  3. Carpenters ladders don't have any need for support. They will hover mid-air if placed there as normal solid blocks. I see it like they work as a "super-ladder" compared to ours and see that our machine builds them i both directions. But that also means we need to actually decide that is how we want them to function.
  4. To make sure our code workes without Carpenters ladders means we would need A LOT of extra checking code and special solutions in our code to make it compile right. This would make the readability of our code much harder.

In summary, is it really worh puting in all the needed energy to make this work with our mod?

holmsten commented 9 years ago

After playing around with Carpenter's Ladders I don't think it's worth it. Textures on the ladders is not saved in the block - but applied on the block (by right-clicking). It means that every time a ladder is replaced with our dispenser you would need to reapply the texture.