Rename "Delimeter" to Delimiter

CodeBeamOrg / CodeBeam.MudBlazor.Extensions

Useful third party extension components for MudBlazor, from the contributors.

https://mudextensions.codebeam.org/

MIT License

410 stars 67 forks source link

Rename "Delimeter" to Delimiter #275

Closed PrimeJoker closed 4 months ago

PrimeJoker commented 1 year ago

fix the build error "Delimiter" does not exist in the current context. Amend to #274 created.

enkodellc commented 8 months ago

This seems like it is a simple fix.

enkodellc commented 6 months ago

@mckaragoz this looks like it can be merged. It fixes a typo.

mckaragoz commented 6 months ago

@mckaragoz this looks like it can be merged. It fixes a typo.

Yes it's done, but it's a breaking change. And not obsoleted the old parameter, directly removed.

PrimeJoker commented 6 months ago

When do you think it can be pushed live?

mckaragoz commented 6 months ago

When do you think it can be pushed live?

If you can obsolete the old parameter instead of completely remove we can merge it today. But currently it's a direct breaking change, users will have errors after update the package, so we need to wait next major release

PrimeJoker commented 6 months ago

@mckaragoz I have reinstated the original parameter name to make it easier to merge pull request.

mckaragoz commented 5 months ago

Hi, its now time to fix this typo, could you prepare a new fresh PR?