search

CodeByZach / pace

Automatically add a progress bar to your site.
https://codebyzach.github.io/pace/
MIT License
15.68k stars 1.9k forks source link

Pace compatibility with ng-file-upload #272

Open Pirozek opened 8 years ago

Pirozek commented 8 years ago

Hi, I was dealing with issue in ng-file-upload in one of my Angular projects and found out, that pace.js was broking the upload library. Problem was with setRequestHeader method on XHR object.

There is very easy fix - https://github.com/danialfarid/ng-file-upload/issues/832#issuecomment-138975388 and it is not breaking any functionality of pace.js

Can you incorporate it in the next version please?

fingul commented 8 years ago

+1

ivcandela commented 8 years ago

+1

benlayar commented 8 years ago

+1

ghost commented 8 years ago

Would be great to get a quick patch here.. it's really a simple fix. I'll submit the PR if someone will merge.

Dufgui commented 8 years ago

+1