Pace.stop() causes extra entries in _intercept.bindings for AjaxMonitor.watch

CodeByZach / pace

Automatically add a progress bar to your site.

https://codebyzach.github.io/pace/

MIT License

15.68k stars 1.9k forks source link

Pace.stop() causes extra entries in _intercept.bindings for AjaxMonitor.watch #489

Open luke-ff opened 5 years ago

luke-ff commented 5 years ago

Tested with chrome and Pace 1.0.2:

Set a breakpoint in the constructor of AjaxMonitor and watch getIntercept().bindings
load a simple html page with Pace on it
call Pace.stop() -> size of getIntercept().bindings will grow with each "Pace.stop()".

This leads to issues when reconnecting WebSockets: Creating a new Websocket triggers Pace.restart, and the request will be watched multiple times.

akvaliya commented 5 years ago

I think you have to add below pace options then it will not track Websocket. window.paceOptions = { ajax: { ignoreURLs: ['signalr', '__browserLink', 'browserLinkSignalR'], trackWebSockets: false } }